Season sensor by w1ll1am23 · Pull Request #8958 · home-assistant/core

w1ll1am23 · 2017-08-13T16:58:26Z

Description:

This sensor will display the current astronomical or meteorological season (Spring, Summer, Autumn, Winter) based on the users setting in the config file.

All information about how the seasons work was taken from Wikipedia:
https://en.wikipedia.org/wiki/Season#Astronomical
https://en.wikipedia.org/wiki/Equinox
https://en.wikipedia.org/wiki/Solstice

I don't expect this to be very useful for anyone in tropical regions because their seasons aren't really anything like the reset of the world. Maybe someone that knows more about that can add support for them? Wet/Dry seasons?

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: season
    type: astronomical (optional, will default to astronomical)

Checklist:

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

Local tests with tox run successfully. Your PR cannot be merged unless tests pass
New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

mention-bot · 2017-08-13T16:58:27Z

@w1ll1am23, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers.

houndci-bot · 2017-08-13T16:58:41Z

no newline at end of file

houndci-bot · 2017-08-13T16:58:41Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:41Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:41Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-13T16:58:42Z

continuation line over-indented for visual indent

Danielhiversen · 2017-08-13T17:41:03Z

Should not be part of this pr

Hmm not sure how that got there, all I did was run gen_requirements_all.py

balloob · 2017-08-23T05:31:40Z

Please don't use STATE_UNKNOWN, instead use None and let Home Assistant handle unknown states.

balloob · 2017-08-23T05:33:40Z

I think that a nice cleanup would be to extract this method from this class and just make it a method in this file . Have it pass datetime as a parameter.

That way it will make your tests also a lot easier, you can test the method directly.

balloob · 2017-08-23T05:53:30Z

It would be faster to create datetimes and just replace the year instead of going via strings

balloob · 2017-08-23T05:54:43Z

Is it really necessary to have all the datetimes of starting points of seasons, couldn't you just check versus the month ?

if 6 <= datetime.month < 9: season = STATE_SUMMER

This is because the seasons don't start with the month. For example this year the first day of fall in the northern hemisphere is 9/22 but in 2019 it will be on 9/23. That is of course if the user is using astronomical seasons.

Oh good point

houndci-bot · 2017-08-28T22:11:43Z

undefined name 'DEVICE'
line too long (95 > 79 characters)

houndci-bot · 2017-08-28T22:11:43Z

undefined name 'DEVICE'
line too long (95 > 79 characters)

houndci-bot · 2017-08-28T22:11:43Z

line too long (81 > 79 characters)

houndci-bot · 2017-08-28T22:11:44Z

line too long (80 > 79 characters)

houndci-bot · 2017-08-28T22:11:44Z

'homeassistant.const.STATE_UNKNOWN' imported but unused

w1ll1am23 · 2017-08-28T22:12:06Z

@balloob I think I have addressed all of your suggestions.

houndci-bot · 2017-08-29T00:05:06Z

continuation line over-indented for visual indent

houndci-bot · 2017-08-29T00:05:06Z

continuation line over-indented for visual indent

pvizeli · 2017-08-29T14:18:59Z

I think you can convert this into a async component in future

* upstream/dev: (113 commits) Fix fitbit error when trying to access token after upgrade. (home-assistant#9183) Upgrade sendgrid to 5.0.1 (home-assistant#9215) Upgrade pyasn1 to 0.3.3 and pyasn1-modules to 0.1.1 (home-assistant#9216) directv: extended discovery via REST api, bug fix (home-assistant#8800) Bayesian Binary Sensor (home-assistant#8810) Add cloud auth support (home-assistant#9208) Abode push events and lock, cover, and switch components (home-assistant#9095) Lint Sonarr tests Upgrade pymysensors to 0.11.1 (home-assistant#9212) Refactor rfxtrx (home-assistant#9117) Issue home-assistant#6893 in rfxtrx (home-assistant#9130) Support for season sensor (home-assistant#8958) Add counter component (home-assistant#9146) Fix and optimize digitalloggers platform (home-assistant#9203) Prevent error when no forecast data was available (home-assistant#9176) Add "status" to Sonarr sensor (home-assistant#9204) fix worldtidesinfo home-assistant#9184 (home-assistant#9201) Update pushbullet.py (home-assistant#9200) Fix dht22 when no data was read initially home-assistant#8976 (home-assistant#9198) Prevent iCloud exceptions in logfile (home-assistant#9179) ...

balloob · 2017-09-09T07:47:06Z

This PR did not include documentation 😞

w1ll1am23 · 2017-09-09T07:50:27Z

Dang, you are right I totally forgot. I'll try to get that added in the next day or two.

balloob · 2017-09-09T07:58:02Z

I've added a stub now since it's release day.

homeassistant added cla-signed new-platform platform: sensor.season labels Aug 13, 2017

houndci-bot reviewed Aug 13, 2017

View reviewed changes

homeassistant added the cla-signed label Aug 13, 2017

Danielhiversen reviewed Aug 13, 2017

View reviewed changes

w1ll1am23 force-pushed the season_sensor branch from 4ee494b to bae17d8 Compare August 13, 2017 18:04

homeassistant added the cla-signed label Aug 13, 2017

pvizeli approved these changes Aug 21, 2017

View reviewed changes

balloob reviewed Aug 23, 2017

View reviewed changes

balloobbot added platform requirement labels Aug 28, 2017

houndci-bot reviewed Aug 28, 2017

View reviewed changes

homeassistant added the cla-signed label Aug 28, 2017

houndci-bot reviewed Aug 29, 2017

View reviewed changes

Support for season sensor

44c6456

w1ll1am23 force-pushed the season_sensor branch from e03bac3 to 44c6456 Compare August 29, 2017 00:07

homeassistant added the cla-signed label Aug 29, 2017

pvizeli merged commit 3e0eb87 into home-assistant:dev Aug 29, 2017

balloob mentioned this pull request Sep 7, 2017

0.53 #9327

Merged

home-assistant locked and limited conversation to collaborators Dec 11, 2017

ghost added integration: season and removed platform: sensor.season labels Mar 21, 2019

Uh oh!

Conversation

w1ll1am23 commented Aug 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

Uh oh!

mention-bot commented Aug 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

w1ll1am23 commented Aug 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pvizeli commented Aug 29, 2017

Uh oh!

balloob commented Sep 9, 2017

Uh oh!

w1ll1am23 commented Sep 9, 2017

Uh oh!

balloob commented Sep 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

w1ll1am23 commented Aug 13, 2017 •

edited

Loading

Example entry for `configuration.yaml` (if applicable):